Deprecated WithMinimumReadDBStatsInterval option#371
Open
tie wants to merge 1 commit into
Open
Conversation
This option is not necessary since database/sql.DB.Stats calls are cheap. Note that go.opentelemetry.io/contrib/instrumentation/runtime instrumentation has a similar option WithMinimumReadMemStatsInterval, but for runtime.ReadMemStats that actually has a noticable performance impact (it does stopTheWorld to read stats). database/sql.DB.Stats, on the other hand, simply acquires a mutex for a short duration to return a consistent snapshot of database statistics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option is not necessary since
database/sql.DB.Statscalls are cheap. Note that go.opentelemetry.io/contrib/instrumentation/runtime instrumentation has a similar optionWithMinimumReadMemStatsInterval, but forruntime.ReadMemStatsthat actually has a noticable performance impact (it doesstopTheWorldto read stats).database/sql.DB.Stats, on the other hand, simply acquires a mutex for a short duration to return a consistent snapshot of database statistics.